From 0278e3a854455a48c53ab394d4c4e65734f535ca Mon Sep 17 00:00:00 2001
From: Meier Lukas <meierschlumpf@gmail.com>
Date: Wed, 1 May 2024 12:05:09 +0200
Subject: [PATCH] fix: add rtl compliance for symbols #366 (#406)

---
 .../[locale]/manage/users/groups/[id]/members/page.tsx    | 8 ++++++--
 apps/nextjs/src/app/[locale]/manage/users/groups/page.tsx | 5 ++++-
 packages/spotlight/src/component.tsx                      | 5 ++++-
 packages/translation/src/lang/de.ts                       | 3 ++-
 packages/translation/src/lang/en.ts                       | 3 ++-
 5 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/apps/nextjs/src/app/[locale]/manage/users/groups/[id]/members/page.tsx b/apps/nextjs/src/app/[locale]/manage/users/groups/[id]/members/page.tsx
index 99d6000c1..a9bdea5f4 100644
--- a/apps/nextjs/src/app/[locale]/manage/users/groups/[id]/members/page.tsx
+++ b/apps/nextjs/src/app/[locale]/manage/users/groups/[id]/members/page.tsx
@@ -14,7 +14,7 @@ import {
 
 import type { RouterOutputs } from "@homarr/api";
 import { api } from "@homarr/api/server";
-import { getScopedI18n } from "@homarr/translation/server";
+import { getI18n, getScopedI18n } from "@homarr/translation/server";
 import { SearchInput, UserAvatar } from "@homarr/ui";
 
 import { AddGroupMember } from "./_add-group-member";
@@ -33,6 +33,7 @@ export default async function GroupsDetailPage({
   params,
   searchParams,
 }: GroupsDetailPageProps) {
+  const t = await getI18n();
   const tMembers = await getScopedI18n("management.page.group.setting.members");
   const group = await api.group.getById({ id: params.id });
 
@@ -49,7 +50,10 @@ export default async function GroupsDetailPage({
       <Title>{tMembers("title")}</Title>
       <Group justify="space-between">
         <SearchInput
-          placeholder={`${tMembers("search")}...`}
+          placeholder={t("common.rtl", {
+            value: tMembers("search"),
+            symbol: "...",
+          })}
           defaultValue={searchParams.search}
         />
         <AddGroupMember
diff --git a/apps/nextjs/src/app/[locale]/manage/users/groups/page.tsx b/apps/nextjs/src/app/[locale]/manage/users/groups/page.tsx
index ff127b286..d41d98d1c 100644
--- a/apps/nextjs/src/app/[locale]/manage/users/groups/page.tsx
+++ b/apps/nextjs/src/app/[locale]/manage/users/groups/page.tsx
@@ -53,7 +53,10 @@ export default async function GroupsListPage(props: GroupsListPageProps) {
         <Title>{t("group.title")}</Title>
         <Group justify="space-between">
           <SearchInput
-            placeholder={`${t("group.search")}...`}
+            placeholder={t("common.rtl", {
+              value: t("group.search"),
+              symbol: "...",
+            })}
             defaultValue={searchParams.search}
           />
           <AddGroup />
diff --git a/packages/spotlight/src/component.tsx b/packages/spotlight/src/component.tsx
index 2f8a729b7..043b7e780 100644
--- a/packages/spotlight/src/component.tsx
+++ b/packages/spotlight/src/component.tsx
@@ -100,7 +100,10 @@ export const Spotlight = () => {
       store={spotlightStore}
     >
       <MantineSpotlight.Search
-        placeholder={t("common.search.placeholder")}
+        placeholder={t("common.rtl", {
+          value: t("common.search.placeholder"),
+          symbol: "...",
+        })}
         leftSection={<IconSearch stroke={1.5} />}
       />
 
diff --git a/packages/translation/src/lang/de.ts b/packages/translation/src/lang/de.ts
index 519b03c09..db314a4a8 100644
--- a/packages/translation/src/lang/de.ts
+++ b/packages/translation/src/lang/de.ts
@@ -144,6 +144,7 @@ export default {
     },
   },
   common: {
+    rtl: "{value}{symbol}",
     action: {
       backToOverview: "Zurück zur Übersicht",
       create: "Erstellen",
@@ -157,7 +158,7 @@ export default {
     },
     noResults: "Keine Ergebnisse gefunden",
     search: {
-      placeholder: "Suche nach etwas...",
+      placeholder: "Suche nach etwas",
       nothingFound: "Nichts gefunden",
     },
   },
diff --git a/packages/translation/src/lang/en.ts b/packages/translation/src/lang/en.ts
index 2a20409d1..52269b0d2 100644
--- a/packages/translation/src/lang/en.ts
+++ b/packages/translation/src/lang/en.ts
@@ -337,6 +337,7 @@ export default {
     },
   },
   common: {
+    rtl: "{value}{symbol}",
     action: {
       add: "Add",
       apply: "Apply",
@@ -383,7 +384,7 @@ export default {
       },
     },
     search: {
-      placeholder: "Search for anything...",
+      placeholder: "Search for anything",
       nothingFound: "Nothing found",
       group: {
         all: "All",