From 02249d20c2578edaea3eaea1507ec8e854433886 Mon Sep 17 00:00:00 2001
From: Tagaishi <Tagaishi@hotmail.ch>
Date: Fri, 9 Feb 2024 22:30:03 +0100
Subject: [PATCH] fix: add check for already existing name upon creating board
 (#1887)

---
 .../Manage/Board/create-board.modal.tsx       |  8 ++++--
 src/server/api/routers/config.ts              | 27 +++++++++++--------
 2 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/src/components/Manage/Board/create-board.modal.tsx b/src/components/Manage/Board/create-board.modal.tsx
index 7cf7abe4e..0f440f0bc 100644
--- a/src/components/Manage/Board/create-board.modal.tsx
+++ b/src/components/Manage/Board/create-board.modal.tsx
@@ -9,12 +9,15 @@ import { createBoardSchemaValidation } from '~/validations/boards';
 
 export const CreateBoardModal = ({ id }: ContextModalProps<{}>) => {
   const { t } = useTranslation('manage/boards');
-  const utils = api.useContext();
+  const utils = api.useUtils();
   const { isLoading, mutate } = api.config.save.useMutation({
     onSuccess: async () => {
       await utils.boards.all.invalidate();
       modals.close(id);
     },
+    onError: async (error) => {
+      form.setFieldError('name', error.message);
+    },
   });
 
   const { i18nZodResolver } = useI18nZodResolver();
@@ -31,6 +34,7 @@ export const CreateBoardModal = ({ id }: ContextModalProps<{}>) => {
     mutate({
       name: form.values.name,
       config: fallbackConfig,
+      create: true,
     });
   };
 
@@ -59,7 +63,7 @@ export const CreateBoardModal = ({ id }: ContextModalProps<{}>) => {
           <Button
             type="submit"
             onClick={async () => {
-              umami.track('Create new board')
+              umami.track('Create new board');
             }}
             disabled={isLoading}
             variant="light"
diff --git a/src/server/api/routers/config.ts b/src/server/api/routers/config.ts
index 10f15912c..6344a70ae 100644
--- a/src/server/api/routers/config.ts
+++ b/src/server/api/routers/config.ts
@@ -19,15 +19,15 @@ export const configRouter = createTRPCRouter({
     .input(
       z.object({
         name: configNameSchema,
-      }),
+      })
     )
     .output(z.object({ message: z.string() }))
     .mutation(async ({ input }) => {
       if (input.name.toLowerCase() === 'default') {
-        Consola.error('Rejected config deletion because default configuration can\'t be deleted');
+        Consola.error("Rejected config deletion because default configuration can't be deleted");
         throw new TRPCError({
           code: 'FORBIDDEN',
-          message: 'Default config can\'t be deleted',
+          message: "Default config can't be deleted",
         });
       }
 
@@ -44,7 +44,7 @@ export const configRouter = createTRPCRouter({
       // If the target is not in the list of files, return an error
       if (!matchedFile) {
         Consola.error(
-          `Rejected config deletion request because config name '${input.name}' was not included in present configurations`,
+          `Rejected config deletion request because config name '${input.name}' was not included in present configurations`
         );
         throw new TRPCError({
           code: 'NOT_FOUND',
@@ -64,9 +64,13 @@ export const configRouter = createTRPCRouter({
       z.object({
         name: configNameSchema,
         config: z.custom<ConfigType>((x) => !!x && typeof x === 'object'),
-      }),
+        create: z.boolean().optional(),
+      })
     )
     .mutation(async ({ input }) => {
+      if (input.create && configExists(input.name))
+        throw new TRPCError({ message: 'Config already exists.', code: 'CONFLICT' });
+
       Consola.info(`Saving updated configuration of '${input.name}' config.`);
 
       const previousConfig = getConfig(input.name);
@@ -96,16 +100,16 @@ export const configRouter = createTRPCRouter({
                 }
 
                 const previousApp = previousConfig.apps.find(
-                  (previousApp) => previousApp.id === app.id,
+                  (previousApp) => previousApp.id === app.id
                 );
 
                 const previousProperty = previousApp?.integration?.properties.find(
-                  (previousProperty) => previousProperty.field === property.field,
+                  (previousProperty) => previousProperty.field === property.field
                 );
 
                 if (property.value !== undefined && property.value !== null) {
                   Consola.info(
-                    'Detected credential change of private secret. Value will be overwritten in configuration',
+                    'Detected credential change of private secret. Value will be overwritten in configuration'
                   );
                   return {
                     field: property.field,
@@ -168,13 +172,14 @@ export const configRouter = createTRPCRouter({
         path: '/configs/byName',
         tags: ['config'],
         deprecated: true,
-        summary: 'Retrieve content of the JSON configuration. Deprecated because JSON will be removed in a future version and be replaced with a relational database.'
-      }
+        summary:
+          'Retrieve content of the JSON configuration. Deprecated because JSON will be removed in a future version and be replaced with a relational database.',
+      },
     })
     .input(
       z.object({
         name: configNameSchema,
-      }),
+      })
     )
     .output(z.custom<ConfigType>())
     .query(async ({ ctx, input }) => {